feat: add quoting support to to_dict (#1052) (#1053) #1061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: See pytorch#1052 Test Plan: [x] all existing test cases pass [x] add new test case [x] test locally: Given: ``` [component:dist.ddp] script=test.py env= NCCL_IB_HCA='=mlx5_0:1,mlx5_1:1'; ``` Observe: ``` test/0 [7]:environ({...'NCCL_IB_HCA': '=mlx5_0:1,mlx5_1:1', ...}) ``` Differential Revision: D74185528 Pulled By: andywag
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D74185528 |
kiukchung
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
See #1052
Test Plan:
[x] all existing test cases pass
[x] add new test case
[x] test locally:
Given:
Observe:
Differential Revision: D74185528
Pulled By: andywag